Add Dwarf::load and Dwarf::borrow #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
Mar 12, 2019
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | ||
| pub enum SectionId { | ||
| /// The `.debug_abbrev` section. | ||
| DebugAbbrev, |
There was a problem hiding this comment.
Nice, I was going to suggest adding this, but looks like you've anticipated it already :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Dwarf::loadin thereadmodule example. See #405 for motivation. If users want to avoid loading some sections then they can handle that in the loader callback.Dwarf::borrowcan be used when theReaderneeds to borrow from something else. In the dwarfdump example we use an arena, but instead of that we could first load everything into aDwarf<Cow<[u8]>>and then borrow that to getDwarf<EndianSlice<_>>. Note that this can't use the standard rustBorrowtrait, and I couldn't come up with a way to define this as aSectiontrait method either (do we need type constructors or something like that?). I didn't update dwarfdump to use this because the arena is still convenient for the sections that aren't inDwarf.