Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the -G flag from the binutils dwarfdump. #427

Merged
merged 2 commits into from
May 16, 2019

Conversation

khuey
Copy link
Contributor

@khuey khuey commented May 10, 2019

No description provided.

@coveralls
Copy link

coveralls commented May 11, 2019

Coverage Status

Coverage decreased (-0.006%) to 86.377% when pulling f265e05 on khuey:dwarfdump-goff into 423431f on gimli-rs:master.

Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean libdwarf dwarfdump :)

How would you feel about removing the -G flag and always displaying the global offset (and not the unit offset)? This is what all other tools that I looked at do (objdump, readelf, llvm-dwarfdump).

examples/dwarfdump.rs Outdated Show resolved Hide resolved
examples/dwarfdump.rs Outdated Show resolved Hide resolved
@khuey
Copy link
Contributor Author

khuey commented May 11, 2019

So I'm not thrilled about only showing the global offset, because 99% of my use of dwarfdump is checking the raw DWARF against what I'm getting out of my gimli embedding, and in gimli the UnitOffset is often what's handy. I wouldn't object to reversing the optionality though (showing global offsets all the time with a flag for the unit offsets).

@philipc
Copy link
Collaborator

philipc commented May 11, 2019

That's fine, let's leave that how you have it then.

@philipc philipc merged commit 87cea7c into gimli-rs:master May 16, 2019
@philipc
Copy link
Collaborator

philipc commented May 16, 2019

Thanks!

@khuey khuey deleted the dwarfdump-goff branch February 2, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants