Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DWARF2 for DW_OP_implicit_pointer #618

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Support DWARF2 for DW_OP_implicit_pointer #618

merged 2 commits into from
Apr 7, 2022

Conversation

crzysdrs
Copy link
Contributor

@crzysdrs crzysdrs commented Apr 7, 2022

In DwarfV2, the address length encoding in DW_OP_implicit_pointer is the encoding address size, not the format word size.

libdwarf/dwarf_loc#L539

philipc
philipc requested changes Apr 7, 2022
View reviewed changes
src/read/op.rs Outdated Show resolved Hide resolved
src/read/op.rs Outdated Show resolved Hide resolved
@crzysdrs crzysdrs requested a review from philipc April 7, 2022 02:02
philipc
philipc approved these changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit 5ba0349 into gimli-rs:master Apr 7, 2022
@crzysdrs crzysdrs mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crzysdrs @philipc