read/cfi: limit the stack depth in UnwindContext #687
Merged
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a better default. Users can switch back to Vec if they need it.
mstange
added a commit
to mstange/gimli
that referenced
this pull request
Mar 11, 2024
PR gimli-rs#687 switched `StoreOnHeap` to use a `Box` with a fixed-size array. This means that, by default, `UnwindContext` will not allocate during unwind, so the primary motivation for providing a custom `UnwindContextStorage` has changed.
mstange
added a commit
to mstange/gimli
that referenced
this pull request
Mar 11, 2024
PR gimli-rs#687 switched `StoreOnHeap` to use a `Box` with a fixed-size array. This means that, by default, `UnwindContext` will not allocate during unwind, so the primary motivation for providing a custom `UnwindContextStorage` has changed. This commit tweaks the docs a little to better match the current state.
philipc
pushed a commit
that referenced
this pull request
Mar 12, 2024
PR #687 switched `StoreOnHeap` to use a `Box` with a fixed-size array. This means that, by default, `UnwindContext` will not allocate during unwind, so the primary motivation for providing a custom `UnwindContextStorage` has changed. This commit tweaks the docs a little to better match the current state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better default. Users can switch back to Vec if they need it.
r? @nbdd0121
Closes #683