Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all tests in coverage #92

Merged
merged 1 commit into from
Sep 5, 2016
Merged

Include all tests in coverage #92

merged 1 commit into from
Sep 5, 2016

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Sep 5, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-87.8%) to 0.145% when pulling 98bcfdf on kcov into 783a0a9 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-87.8%) to 0.128% when pulling 98bcfdf on kcov into 783a0a9 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-87.8%) to 0.128% when pulling 98bcfdf on kcov into 783a0a9 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.6%) to 93.585% when pulling 5804a34 on kcov into 783a0a9 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.8%) to 89.786% when pulling bc8e71c on kcov into 783a0a9 on master.

Also include dead code in the coverage information.
@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 88.942% when pulling c38e004 on kcov into 783a0a9 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 88.942% when pulling c38e004 on kcov into 783a0a9 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 88.942% when pulling c38e004 on kcov into 783a0a9 on master.

@philipc
Copy link
Collaborator Author

philipc commented Sep 5, 2016

Cargo only creates temporary executables for doc tests, so they can't be included.

I haven't added benches/examples yet. They shouldn't be hard to add, but they're not actually tests, so not sure they should be included.

I can't browse the files on coveralls.io anymore with this change, but I can't see what might have caused that.

We're currently doing coverage for stable, beta and nightly. Is that useful or should we change it to stable only?

@fitzgen
Copy link
Member

fitzgen commented Sep 5, 2016

I can't browse the files on coveralls.io anymore with this change, but I can't see what might have caused that.

In order to make them browse-able initially, I had to set "src" as the root path somewhere in the coveralls settings. I guess this broke that because now there are also files whose path starts with "tests".

@fitzgen
Copy link
Member

fitzgen commented Sep 5, 2016

Thanks for tackling this @philipc :)

@fitzgen fitzgen merged commit 4d866f6 into master Sep 5, 2016
@fitzgen
Copy link
Member

fitzgen commented Sep 5, 2016

I can't browse the files on coveralls.io anymore with this change, but I can't see what might have caused that.

In order to make them browse-able initially, I had to set "src" as the root path somewhere in the coveralls settings. I guess this broke that because now there are also files whose path starts with "tests".

Ok should be fixed now, eg: https://coveralls.io/builds/7752904/source?filename=src%2Fline.rs

@philipc philipc deleted the kcov branch September 5, 2016 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants