Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE exports by ordinal #349

Merged
merged 15 commits into from
Aug 13, 2021
Merged

PE exports by ordinal #349

merged 15 commits into from
Aug 13, 2021

Conversation

daladim
Copy link
Contributor

@daladim daladim commented Aug 9, 2021

This MR adds supports for PE exports by ordinal.

Also, this adds the "forwarded export", which is another PE-specific concept

@daladim daladim changed the title Pe exports PE exports Aug 9, 2021
@daladim daladim changed the title PE exports PE exports by ordinal Aug 9, 2021
PE exports can be either:
* forwarded to another DLL
* in the current PE file

Additionally, each of them can either:
* have a name (and an ordinal)
* have only an ordinal
src/read/pe/file.rs Outdated Show resolved Hide resolved
src/read/pe/pe_export.rs Outdated Show resolved Hide resolved
src/read/pe/pe_export.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start and I'm happy to merge with the requested changes, but later we'll need to add raw parsing via ExportTable.

src/read/pe/pe_export.rs Outdated Show resolved Hide resolved
src/read/pe/file.rs Outdated Show resolved Hide resolved
src/read/mod.rs Show resolved Hide resolved
src/read/pe/file.rs Outdated Show resolved Hide resolved
@daladim daladim force-pushed the pe_exports branch 3 times, most recently from c619281 to b1cca7a Compare August 11, 2021 09:44
src/read/pe/export.rs Show resolved Hide resolved
src/read/pe/export.rs Outdated Show resolved Hide resolved
src/read/pe/export.rs Outdated Show resolved Hide resolved
@philipc philipc merged commit ff17df8 into gimli-rs:master Aug 13, 2021
@daladim daladim deleted the pe_exports branch September 10, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants