Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unified flags (SegmentFlags) for ObjectSegment #416

Merged
merged 4 commits into from
Jan 1, 2022
Merged

Add unified flags (SegmentFlags) for ObjectSegment #416

merged 4 commits into from
Jan 1, 2022

Conversation

everettjf
Copy link
Contributor

@everettjf everettjf commented Dec 29, 2021 •
edited

To solve #414

Changes:

  • Add unified flags for ObjectSegment
  • Add SegmentFlags

@everettjf
Add unified rwe_flags (SEGMENT_RWE_FLAG_READ | SEGMENT_RWE_FLAG_WRITE…
f266288 
… | SEGMENT_RWE_FLAG_EXECUTE) for ObjectSegment
@everettjf everettjf changed the title Add unified rwe_flags (SEGMENT_RWE_FLAG_READ | SEGMENT_RWE_FLAG_WRITE… Add unified rwe_flags for ObjectSegment Dec 29, 2021
philipc
philipc requested changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't think about this enough when looking at the issue. I think we should add a SegmentFlags definition and return that instead. This will be consistent with how we handle other flags (file flags and section flags), and allow us to handle any other flags in addition to rwe.

src/common.rs Outdated Show resolved Hide resolved
crates/examples/src/bin/segments.rs Outdated Show resolved Hide resolved
src/read/coff/section.rs Outdated Show resolved Hide resolved
src/read/traits.rs Outdated Show resolved Hide resolved
@everettjf
Copy link
Contributor Author

Thanks for review. I will fix all soon

@everettjf
Copy link
Contributor Author

Almost all suggestions are fixed. Please review once again :)

philipc
philipc requested changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs the build fix for Wasm.

@everettjf everettjf changed the title Add unified rwe_flags for ObjectSegment Add unified flags (SegmentFlags) for ObjectSegment Dec 31, 2021
@everettjf
Copy link
Contributor Author

emmmm

philipc
philipc approved these changes Jan 1, 2022
View reviewed changes
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit 3c7a3d0 into gimli-rs:master Jan 1, 2022
@everettjf
Copy link
Contributor Author

@philipc Hi, could you publish a new minor version release ?

@philipc
Copy link
Contributor

philipc commented Jan 7, 2022

Ok, I will soon. FYI, see #418

@philipc
Copy link
Contributor

philipc commented Jan 9, 2022

Released 0.28.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@everettjf @philipc