Add GNU Property Types

[cchiw]

Adds GNU Property Type constants.

We are using them in Rust PR to emit notes.
A previous CL added a property constant CL.

[philipc]

let pr_data: u32 = 3; // Program property descriptor

Can you add constants for this value as well (it appears to be architecture specific, for example GNU_PROPERTY_X86_FEATURE_1_IBT | GNU_PROPERTY_X86_FEATURE_1_SHSTK).

let pr_padding: u32 = 3;

It seems unusual to have a non-zero value for padding.

[cchiw]

let pr_data: u32 = 3; // Program property descriptor

Can you add constants for this value as well (it appears to be architecture specific, for example GNU_PROPERTY_X86_FEATURE_1_IBT | GNU_PROPERTY_X86_FEATURE_1_SHSTK).

yup, done.

let pr_padding: u32 = 3;

It seems unusual to have a non-zero value for padding.
I changed it to 0 and it works. Thank you.

[philipc]

Thanks!

[philipc]

FYI, it looks like you squashed your commit into one of the existing commits.

[stephenhines]

https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/BinaryFormat/ELF.h#L1675 shows that there is a typo here. It should be 1 << 1 instead of a duplicate 1 << 0. Should I upload a fix?

[philipc]

Thanks for noticing that. I plan to do further work in this area and I'll fix that at the same time.

[cchiw]

Hi, I want to learn more about how crates get updated. When can we expect this code to be merged into upstream Rust?

[philipc]

For non-breaking changes, I do a release as needed. For breaking changes, I like to delay if possible since it causes other crates to need to update and do a release too.

I'm in the process of doing a release now: #546. Since there aren't any breaking changes, it should be trivial to use this in upstream Rust.

Also, in #541 I did some further work related to this PR which may interest you.

[philipc]

Released in 0.31.1

[cchiw]

Cool! I'm going to try to incorporate this in and work on a PR. Unless you already had one started?

[philipc]

There's already rust-lang/rust#111413 for updating object.