Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read: improve symbol map #606

Merged
merged 2 commits into from
Dec 5, 2023
Merged

read: improve symbol map #606

merged 2 commits into from
Dec 5, 2023

Conversation

philipc
Copy link
Contributor

@philipc philipc commented Dec 4, 2023

Modify is_definition for most file formats to return a better set of symbols, and modify symbol_map to choose between symbols that have the same address.

Closes #447

Also for XCOFF, include label definitions, since they sometimes
provide names that are not given by the csect definitions,
and include common definitions, since they do have addresses.

Also for Wasm, include data symbols.
@philipc philipc merged commit 194273e into gimli-rs:master Dec 5, 2023
12 checks passed
@philipc philipc deleted the symbol-map branch December 5, 2023 06:21
mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant