Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If "*" value is present in the list, all origins will be allowed. #47

Merged
merged 1 commit into from
Dec 6, 2018
Merged

If "*" value is present in the list, all origins will be allowed. #47

merged 1 commit into from
Dec 6, 2018

Conversation

billyplus
Copy link
Contributor

According to godoc

// AllowedOrigins is a list of origins a cross-domain request can be executed from.
// If the special "*" value is present in the list, all origins will be allowed.

This feature is missing.
So this pull request is about to fix it.

@codecov-io
Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #47 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   92.89%   93.02%   +0.12%     
==========================================
  Files           3        3              
  Lines         169      172       +3     
==========================================
+ Hits          157      160       +3     
  Misses         11       11              
  Partials        1        1
Impacted Files Coverage Δ
cors.go 81.53% <100%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488de3e...51fe3ba. Read the comment docs.

@appleboy appleboy merged commit 7c641a7 into gin-contrib:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants