Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router: handling file not found in StaticFS() to use Router's NoRoute #1220

Closed
wants to merge 2 commits into from

Conversation

oantoro
Copy link

@oantoro oantoro commented Jan 3, 2018

Refs #1182

@oantoro oantoro changed the title router: handling file not found in StaticFS() to use Router's NoRouter router: handling file not found in StaticFS() to use Router's NoRoute Jan 3, 2018
@oantoro
Copy link
Author

oantoro commented Jan 3, 2018

CI error due to fetching dependencies timed out in Go version master.

@se3000
Copy link

se3000 commented Jun 7, 2018

@okyantoro if you rebase and push, it should kick off a new travis build.

@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #1220 into master will decrease coverage by 0.25%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
- Coverage   99.27%   99.01%   -0.26%     
==========================================
  Files          39       39              
  Lines        1931     1937       +6     
==========================================
+ Hits         1917     1918       +1     
- Misses         10       14       +4     
- Partials        4        5       +1
Impacted Files Coverage Δ
routergroup.go 94.44% <16.66%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65e5ef...b1a6b51. Read the comment docs.

@thinkerou
Copy link
Member

@okyantoro please add unit/integration test case, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants