Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use http.Status* instead of hard code #1482

Merged
merged 3 commits into from
Aug 14, 2018
Merged

chore: use http.Status* instead of hard code #1482

merged 3 commits into from
Aug 14, 2018

Conversation

thinkerou
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #1482 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1482   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          36       36           
  Lines        1890     1890           
=======================================
  Hits         1874     1874           
  Misses         13       13           
  Partials        3        3
Impacted Files Coverage Δ
render/redirect.go 100% <ø> (ø) ⬆️
logger.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aef947...f1bf918. Read the comment docs.

appleboy
appleboy previously approved these changes Aug 14, 2018
use http.Status*

use hard code for example

fix bug for go1.6

fix code style
@thinkerou
Copy link
Member Author

Oh, sorry @appleboy still have one error with go1.6.

@appleboy appleboy merged commit f45c928 into gin-gonic:master Aug 14, 2018
salamer pushed a commit to salamer/gin that referenced this pull request Aug 18, 2018
@thinkerou thinkerou deleted the hs branch August 19, 2018 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants