Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Make script when failed #1774

Merged
merged 5 commits into from
Feb 21, 2019
Merged

chore: fix Make script when failed #1774

merged 5 commits into from
Feb 21, 2019

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Feb 20, 2019

before:

# github.com/gin-gonic/gin
/tmp/go-build038919107/github.com/gin-gonic/gin/_test/_obj_test/context.go:719:11: unknown field 'SameSite' in struct literal of type http.Cookie
FAIL	github.com/gin-gonic/gin [build failed]
The command "make test" exited with 0.

And

# github.com/gin-gonic/gin/render
package github.com/gin-gonic/gin/render (test)
	imports github.com/stretchr/testify/assert
	imports github.com/pmezard/go-difflib/difflib: cannot find package "github.com/pmezard/go-difflib/difflib" in any of:
	/home/travis/gopath/src/github.com/gin-gonic/gin/vendor/github.com/pmezard/go-difflib/difflib (vendor tree)
	/home/travis/.gimme/versions/go1.8.7.linux.amd64/src/github.com/pmezard/go-difflib/difflib (from $GOROOT)
	/home/travis/gopath/src/github.com/pmezard/go-difflib/difflib (from $GOPATH)
FAIL	github.com/gin-gonic/gin/render [setup failed]

when test case failed, it should return 1 not 0.

For example #1615

@thinkerou thinkerou self-assigned this Feb 20, 2019
@thinkerou thinkerou added this to the 1.4 milestone Feb 20, 2019
@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #1774 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1774   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files          41       41           
  Lines        2046     2046           
=======================================
  Hits         2015     2015           
  Misses         19       19           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a58a2f9...1a31495. Read the comment docs.

@thinkerou thinkerou merged commit e6886e1 into gin-gonic:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants