Sync route tree to httprouter latest code #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2368 +/- ##
==========================================
+ Coverage 98.48% 98.63% +0.15%
==========================================
Files 41 41
Lines 2305 2349 +44
==========================================
+ Hits 2270 2317 +47
+ Misses 20 18 -2
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
thinkerou
reviewed
May 10, 2020
gin.go
Outdated
| @@ -256,13 +258,20 @@ func (engine *Engine) addRoute(method, path string, handlers HandlersChain) { | |||
| assert1(len(handlers) > 0, "there must be at least one handler") | |||
|
|
|||
| debugPrintRoute(method, path, handlers) | |||
| varsCount := uint16(0) | |||
There was a problem hiding this comment.
this zero value local var is't reassign value.
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
thinkerou
reviewed
May 10, 2020
tree.go
Outdated
| if len(n.children) == 1 { | ||
| if n.handlers != nil { | ||
| return ciPath | ||
| } else if fixTrailingSlash && len(n.children) == 1 { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Paramsin context.maxParamscounts to engine