Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(context): return GIN Context from Value method #2825

Merged

Conversation

ifaisalalam
Copy link
Contributor

@ifaisalalam ifaisalalam commented Aug 14, 2021

Closes #2824

@ifaisalalam ifaisalalam force-pushed the ifaisalalam/feat/return-self branch 3 times, most recently from 73f456c to 7220d2a Compare Aug 14, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2825 (2f7c905) into master (b463b1c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2825      +/-   ##
==========================================
+ Coverage   98.71%   98.76%   +0.04%     
==========================================
  Files          41       41              
  Lines        2100     3065     +965     
==========================================
+ Hits         2073     3027     +954     
- Misses         15       26      +11     
  Partials       12       12              
Flag Coverage Δ
go-1.13 98.76% <100.00%> (?)
go-1.14 98.59% <100.00%> (?)
go-1.15 98.59% <100.00%> (?)
go-1.16 98.59% <100.00%> (?)
go-1.17 98.49% <100.00%> (?)
macos-latest 98.76% <100.00%> (?)
nomsgpack 98.74% <100.00%> (?)
ubuntu-latest 98.76% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
context.go 97.99% <100.00%> (+0.26%) ⬆️
render/json.go 83.14% <0.00%> (-2.15%) ⬇️
gin.go 99.09% <0.00%> (-0.09%) ⬇️
utils.go 96.80% <0.00%> (-0.02%) ⬇️
fs.go 100.00% <0.00%> (ø)
auth.go 100.00% <0.00%> (ø)
mode.go 100.00% <0.00%> (ø)
path.go 100.00% <0.00%> (ø)
tree.go 100.00% <0.00%> (ø)
debug.go 100.00% <0.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b463b1c...2f7c905. Read the comment docs.

context.go Outdated Show resolved Hide resolved
@ifaisalalam
Copy link
Contributor Author

ifaisalalam commented Dec 25, 2021

Hi @appleboy @thinkerou @javierprovecho! Could you please help review this PR?

I have described the use case in the issue #2824.

Thanks!

@appleboy appleboy added this to the v1.8 milestone Apr 23, 2022
@appleboy appleboy requested a review from thinkerou Apr 23, 2022
@appleboy
Copy link
Member

appleboy commented Apr 23, 2022

@thinkerou Please help to review.

@thinkerou thinkerou merged commit e61cc06 into gin-gonic:master Apr 23, 2022
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants