Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused arg #2834

Merged
merged 1 commit into from Aug 21, 2021
Merged

Delete unused arg #2834

merged 1 commit into from Aug 21, 2021

Conversation

sashamelentyev
Copy link
Contributor

@sashamelentyev sashamelentyev commented Aug 20, 2021

This PR is sponsored by Evrone

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #2834 (af4d74b) into master (f3a6b69) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2834   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          41       41           
  Lines        3063     3063           
=======================================
  Hits         3025     3025           
  Misses         26       26           
  Partials       12       12           
Flag Coverage Δ
go-1.13 98.75% <100.00%> (ø)
go-1.14 98.59% <100.00%> (ø)
go-1.15 98.59% <100.00%> (ø)
go-1.16 98.59% <100.00%> (ø)
macos-latest 98.75% <100.00%> (ø)
nomsgpack 98.74% <100.00%> (ø)
ubuntu-latest 98.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
binding/form_mapping.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a6b69...af4d74b. Read the comment docs.

@sashamelentyev
Copy link
Contributor Author

sashamelentyev commented Aug 20, 2021

@appleboy @thinkerou

Copy link
Member

@thinkerou thinkerou left a comment

lgtm

@thinkerou thinkerou added this to the v1.8 milestone Aug 21, 2021
@thinkerou thinkerou merged commit 527d950 into gin-gonic:master Aug 21, 2021
20 checks passed
daheige pushed a commit to daheige/gin that referenced this issue Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants