Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add short func with named return #2837

Merged
merged 1 commit into from Aug 22, 2021
Merged

Add short func with named return #2837

merged 1 commit into from Aug 22, 2021

Conversation

sashamelentyev
Copy link
Contributor

@sashamelentyev sashamelentyev commented Aug 21, 2021

This PR is sponsored by Evrone

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #2837 (7e0eb24) into master (527d950) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2837      +/-   ##
==========================================
- Coverage   98.75%   98.75%   -0.01%     
==========================================
  Files          41       41              
  Lines        3063     3059       -4     
==========================================
- Hits         3025     3021       -4     
  Misses         26       26              
  Partials       12       12              
Flag Coverage Δ
go-1.13 98.75% <100.00%> (-0.01%) ⬇️
go-1.14 98.59% <100.00%> (-0.01%) ⬇️
go-1.15 98.59% <100.00%> (-0.01%) ⬇️
go-1.16 98.59% <100.00%> (-0.01%) ⬇️
macos-latest 98.75% <100.00%> (-0.01%) ⬇️
nomsgpack 98.73% <100.00%> (-0.01%) ⬇️
ubuntu-latest 98.75% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
context.go 97.97% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527d950...7e0eb24. Read the comment docs.

@sashamelentyev
Copy link
Contributor Author

sashamelentyev commented Aug 21, 2021

@appleboy @thinkerou

@appleboy appleboy added this to the v1.8 milestone Aug 21, 2021
@appleboy appleboy requested a review from thinkerou Aug 21, 2021
Copy link
Member

@thinkerou thinkerou left a comment

lgtm

@thinkerou thinkerou merged commit dfc25f9 into gin-gonic:master Aug 22, 2021
19 of 20 checks passed
daheige pushed a commit to daheige/gin that referenced this issue Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants