Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check obj type in protobufBinding #2851

Merged
merged 2 commits into from Sep 7, 2021
Merged

Conversation

Tevic
Copy link
Contributor

@Tevic Tevic commented Aug 31, 2021

Change-Id: I194f7010835974b489b497c6d1f1b4e47b99864e

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

Solve #2850

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #2851 (479ec1a) into master (30cdbfc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2851   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          41       41           
  Lines        3054     3058    +4     
=======================================
+ Hits         3016     3020    +4     
  Misses         26       26           
  Partials       12       12           
Flag Coverage Δ
go-1.13 98.75% <100.00%> (+<0.01%) ⬆️
go-1.14 98.59% <100.00%> (+<0.01%) ⬆️
go-1.15 98.59% <100.00%> (+<0.01%) ⬆️
go-1.16 98.59% <100.00%> (+<0.01%) ⬆️
macos-latest 98.75% <100.00%> (+<0.01%) ⬆️
nomsgpack 98.73% <100.00%> (+<0.01%) ⬆️
ubuntu-latest 98.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
binding/protobuf.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30cdbfc...479ec1a. Read the comment docs.

binding/protobuf.go Show resolved Hide resolved
@appleboy appleboy added this to the v1.8 milestone Aug 31, 2021
@appleboy
Copy link
Member

appleboy commented Sep 2, 2021

build fail

@Tevic Tevic requested a review from appleboy Sep 3, 2021
daheige
daheige approved these changes Sep 6, 2021
Copy link
Member

@thinkerou thinkerou left a comment

lgtm

@thinkerou thinkerou merged commit eab47b5 into gin-gonic:master Sep 7, 2021
20 checks passed
daheige pushed a commit to daheige/gin that referenced this issue Apr 18, 2022
* fix: check obj type in protobufBinding

* fix: UnitTest for invalid proto obj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants