Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always trust xff headers from unix socket #3359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WeidiDeng
Copy link

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

Fix 2718. Users no longer need to hack TrustedPlatform to bypass empty client IP from unix socket.

@daenney
Copy link

daenney commented May 29, 2024

@appleboy @thinkerou Is there someone who could take a look at this? It would be a very welcome quality of life change for folks who would like to run Gin bound on a socket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty Context.ClientIP() when listening on unix socket
2 participants