Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(context): Added deprecation comments to BindWith #3880

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

flc1125
Copy link
Contributor

@flc1125 flc1125 commented Mar 12, 2024

I hope to achieve that the IDE can recognize deprecated methods and guide users with correct prompts.

image

@appleboy appleboy added this to the v1.10 milestone Mar 12, 2024
@appleboy
Copy link
Member

@flc1125 Please help to rebase the master branch to fix the testing.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (3dc1cd6) to head (270c902).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3880      +/-   ##
==========================================
- Coverage   99.21%   99.18%   -0.03%     
==========================================
  Files          42       43       +1     
  Lines        3182     2701     -481     
==========================================
- Hits         3157     2679     -478     
+ Misses         17       12       -5     
- Partials        8       10       +2     
Flag Coverage Δ
?
-tags go_json 99.17% <ø> (?)
-tags nomsgpack 99.17% <ø> (?)
go-1.18 99.11% <ø> (-0.01%) ⬇️
go-1.19 99.18% <ø> (-0.03%) ⬇️
go-1.20 99.18% <ø> (-0.03%) ⬇️
go-1.21 ?
macos-latest ?
ubuntu-latest 99.18% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appleboy appleboy merged commit 990c44a into gin-gonic:master Mar 12, 2024
29 of 55 checks passed
@flc1125 flc1125 deleted the doc-deprecated branch March 12, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants