-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(binding): add BindPlain #3904
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3904 +/- ##
==========================================
- Coverage 99.21% 99.12% -0.10%
==========================================
Files 42 44 +2
Lines 3182 2739 -443
==========================================
- Hits 3157 2715 -442
+ Misses 17 14 -3
- Partials 8 10 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It seems that running go test -tags "sonic avx" -v -covermode=count -coverprofile=profile.out will cause a panic. However, I couldn't reproduce this panic because my CPU doesn't support AVX 512 instructions I've noticed several PRs with the same panic. It seems that the semantic differences between Sonic and the standard library might be causing this, or it could be a bug in Sonic. |
@@ -614,7 +614,7 @@ func (c *Context) SaveUploadedFile(file *multipart.FileHeader, dst string) error | |||
} | |||
defer src.Close() | |||
|
|||
if err = os.MkdirAll(filepath.Dir(dst), 0750); err != nil { | |||
if err = os.MkdirAll(filepath.Dir(dst), 0o750); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution should be exercised regarding permission modifications to files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines of code are actually the same, except for the representation of file permissions using different formats for octal notation.
In the first line, the file permissions are represented using octal notation, specifically 0750. In octal notation, a number starting with 0 denotes that it's an octal number. Therefore, 0750 represents permissions set to rwxr-x--- (i.e., the owner has read, write, and execute permissions, the group users have read and execute permissions, and others have no permissions).
In the second line, the new octal literal notation is used, denoted by 0o750. In this notation, numbers start with 0o to indicate octal representation. So, 0o750 also represents permissions set to rwxr-x---.
In summary, these two lines of code are entirely equivalent; they just use different formats for representing permissions when using octal notation.
#2037