Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #23

Merged
merged 81 commits into from
Jan 20, 2022
Merged

Develop #23

merged 81 commits into from
Jan 20, 2022

Conversation

gin0115
Copy link
Owner

@gin0115 gin0115 commented Jan 20, 2022

No description provided.

… the possibility of closures with values that are sanitized.
…d models isnt ideal, this need to be revisted as im not 100% sure how its suppoed to actually work. Having issues around definig a global type for MODELS that can be defined as class name stirng and as an instance. It errors when using a return of T as cantuse @template T unless its passed as a param. This seems by design!
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022

Codecov Report

Merging #23 (9e0965c) into master (8bcaf5b) will decrease coverage by 0.91%.
The diff coverage is 95.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #23      +/-   ##
============================================
- Coverage     97.61%   96.70%   -0.92%     
- Complexity      267      372     +105     
============================================
  Files            11       12       +1     
  Lines           714      910     +196     
============================================
+ Hits            697      880     +183     
- Misses           17       30      +13     
Impacted Files Coverage Δ
src/QueryBuilder/WPDBAdapter.php 94.77% <90.35%> (-2.02%) ⬇️
src/QueryBuilder/QueryBuilderHandler.php 96.36% <95.23%> (-0.76%) ⬇️
src/AliasFacade.php 100.00% <100.00%> (ø)
src/Binding.php 100.00% <100.00%> (ø)
src/Connection.php 100.00% <100.00%> (ø)
src/EventHandler.php 100.00% <100.00%> (ø)
src/Hydration/Hydrator.php 100.00% <100.00%> (ø)
src/QueryBuilder/JoinBuilder.php 100.00% <100.00%> (ø)
src/QueryBuilder/NestedCriteria.php 100.00% <100.00%> (ø)
src/QueryBuilder/QueryObject.php 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcaf5b...9e0965c. Read the comment docs.

@gin0115 gin0115 merged commit 500a633 into master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants