Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing gb_math.h #14

Closed
wants to merge 1 commit into from
Closed

Fixing gb_math.h #14

wants to merge 1 commit into from

Conversation

jimon
Copy link
Contributor

@jimon jimon commented Nov 20, 2016

I guess + was meant there.

@jimon
Copy link
Contributor Author

jimon commented Nov 20, 2016

Hey, it's still broken after that column-row major wise, check this out:

 --------- inverting 
0.220 0.000 0.000 345.000
0.000 -0.220 0.000 365.200
0.000 0.000 -1.000 0.000
0.000 0.000 0.000 1.000
 --------- result from gb_mat4_inverse
4.545 -0.000 0.000 -0.000
-0.000 -4.545 -0.000 0.000
0.000 -0.000 -1.000 -0.000
-1568.182 1660.000 -0.000 1.000
 --------- should be 
4.545 -0.000 0.000 -1568.182
-0.000 -4.545 -0.000 1660.000
0.000 -0.000 -1.000 -0.000
-0.000 0.000 -0.000 1.000

I can transpose the matrix, no worries, maybe we should create a test suite of sorts?

@gingerBill
Copy link
Owner

Yes it is. I will update this soon. I'm a little amazed this wasn't even picked up by the compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants