Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search annotation by qualifiers #28

Closed
wants to merge 1 commit into from

Conversation

benjiec
Copy link
Contributor

@benjiec benjiec commented Oct 17, 2018

Hi Yaoyu, can you take a look at this? Also, I can't build the dockerfile locally, does that work? And how does on bump the version? Thanks.

@yaoyuyang
Copy link
Member

The local docker should work though. What error are you seeing?

@yaoyuyang
Copy link
Member

Also there seems to be a syntax error, the CI is failing.

@benjiec
Copy link
Contributor Author

benjiec commented Oct 17, 2018

I just checked them in, but I am trying to load the local docker to test things. I can't because it says it can't install npm

@yaoyuyang
Copy link
Member

Let me try it out locally!

@yaoyuyang
Copy link
Member

I tried build locally using docker-compose build --no-cache and it built without errors. Can you try clean up your docker space? https://gist.github.com/yaoyuyang/c78c84aa0f69fa6b96a892664b3b2af9
Sometimes docker will report errors if there are not enough space on your docker space allocation.

@yaoyuyang
Copy link
Member

For updating the version after pulled in, https://github.com/ginkgobioworks/edge#versioning.

@benjiec benjiec closed this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants