Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup fullstory recording #34

Merged
merged 6 commits into from
Nov 1, 2019
Merged

Setup fullstory recording #34

merged 6 commits into from
Nov 1, 2019

Conversation

yaoyuyang
Copy link
Member

@yaoyuyang yaoyuyang requested a review from dpca October 29, 2019 15:43
Copy link
Member

@dpca dpca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question and a suggestion for the code, but mostly looks good. Have you tested this locally or on staging to see if it works?

src/edge/templates/edge/edge.html Show resolved Hide resolved
src/edge/templates/edge/edge.html Show resolved Hide resolved
@yaoyuyang
Copy link
Member Author

Thanks @dpca for reviewing, let me try getting local working on uploading data to fullstory before we merge this.

@yaoyuyang
Copy link
Member Author

@dpca I tested locally and it works as expected with these additional commits. I also added Add fs-block to genome name, fragment name, sequence per Product's request to prevent possible leak of proprietary information.

Copy link
Member

@dpca dpca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yaoyuyang yaoyuyang merged commit 7fddd87 into master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants