Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pybind11 module updated #71

Merged
merged 3 commits into from
Mar 7, 2024
Merged

pybind11 module updated #71

merged 3 commits into from
Mar 7, 2024

Conversation

rballeba
Copy link
Contributor

This update allows to install giotto-ph on Python 3.11 and below. The project only needed to update the pybind11 library.

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gmacon gmacon mentioned this pull request Nov 14, 2023
Open
@nwaniek nwaniek mentioned this pull request Jan 25, 2024
Closed
@rballeba
Copy link
Contributor Author

rballeba commented Mar 6, 2024

@ulupo This is the pull request for pybinds version in giotto-ph.

ulupo
ulupo approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@ulupo ulupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! I've also updated wheels.yml to add Python 3.11 there, so that 3.11 wheels can also be built. Will merge if CI passes.

@ulupo ulupo merged commit b5fd32b into giotto-ai:main Mar 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulupo ulupo ulupo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rballeba @CLAassistant @ulupo