Reduce the number of dependencies #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
That dependency brings in a lot of other dependencies, which makes integrating this into other projects more difficult. Rewrote the tracing to use `log` package that's only included when uaxtrace tag is used. For example: go test -tags uaxtrace -v ./... Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Currently UCD data was spread out across multiple packages. Move the data into a single folder and add script for downloading the data. Signed-off-by: Egon Elbre <egonelbre@gmail.com>
This makes generators repeatable. Signed-off-by: Egon Elbre <egonelbre@gmail.com>
This way the range tables are much smaller. Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
It looks like the previous generator was not working properly.
Some runes cannot be printed with %+q, because they do not result in a valid
string. Hence the Control range table ended up with wrong set:
fmt.Printf("%+q", 0xD800)
// Outputs \uFFFD
// Expected \uD800
The code should use %x or %U or %#U to avoid rune sanitization.
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
It's easier to update ucd data, if they aren't manually modified. Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Changes to prepare for unifying table generation. Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Output the range tables on separate lines, this makes diffs to updates shorter and also the line lengths are smaller. Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Use classgen for generating the tables to reduce the amount of code needed to maintain. This also uses the v11 of Unicode data to ensure consistency across packages. Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
The jibber_jabber dependency causes a lot of additional dependencies, it would be nicer to reimplemnt, however, we'll remove it for now. Signed-off-by: Egon Elbre <egonelbre@gmail.com>
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
whereswaldon
requested changes
Aug 19, 2022
There was a problem hiding this comment.
I apologize for this sitting for so long. This set of enhancements is fantastic, and I thank you so much for putting it together. I have no concerns with the changes themselves. It looks like some excellent simplification and optimization.
However, I do think we need to clean up the git metadata. If Gio is going to maintain this, we're going to follow our conventions in doing so. @npillmayer relicensed his repo under the UNLICENSE for better compatibility with us (which was very kind), and now we should follow the same sign-off process here that we use for other Gio projects to indicate acceptance of the license.
So can you just sign-off these commits? I think we should be good after that.
Signed-off-by: Egon Elbre <egonelbre@gmail.com>
|
@whereswaldon ok, finally figured out the correct git commands. |
whereswaldon
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains many improvements to the generated code and removes dependencies not needed for gio.