Audit view#13 #25
Merged
Audit view#13 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/Interface-improvements # Conflicts: # client/src/app/app.module.ts # client/src/app/shared/shared.module.ts
…into feature/Interface-improvements
|
Token in shared module is not committed and the build fails. But why use it? I see that token is a random string added to the filter and if there is a token then the view export a file to excel and then another request is made to download the file, that is totally bad practice. The code also tries to work around by removing the token from the filter, because token is not a filter. Please read https://www.soapui.org/testing-dojo/best-practices/understanding-rest-headers-and-parameters.html I will refactor the code to use the Accept header instead. There is other things to refactor. That is a really nice feature well done! |
added 2 commits
May 13, 2017 19:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.