Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add quality score to api #279

Merged
merged 4 commits into from
Oct 24, 2024
Merged

feat(api): add quality score to api #279

merged 4 commits into from
Oct 24, 2024

Conversation

vmttn
Copy link
Contributor

@vmttn vmttn commented Aug 25, 2024

No description provided.

@vmttn vmttn force-pushed the vmttn/feat/add-quality-scoring-to-api branch 3 times, most recently from db8769c to 5960a3c Compare September 16, 2024 14:21
@vmttn vmttn marked this pull request as ready for review September 16, 2024 15:21
@vmttn vmttn force-pushed the vmttn/feat/add-quality-scoring-to-api branch from 5960a3c to 69e914e Compare September 16, 2024 15:34
@vmttn vmttn force-pushed the vmttn/feat/add-quality-scoring-to-api branch from 69e914e to eff8df3 Compare September 16, 2024 15:46
@vmttn vmttn force-pushed the vmttn/feat/add-quality-scoring-to-api branch from eff8df3 to 7cf4df0 Compare September 23, 2024 08:55
@vmttn vmttn force-pushed the vmttn/feat/add-quality-scoring-to-api branch from 7cf4df0 to 3d61d10 Compare September 27, 2024 13:41
@vmttn vmttn force-pushed the vmttn/feat/add-quality-scoring-to-api branch 2 times, most recently from 9238bd4 to 40ab839 Compare October 22, 2024 12:33
vperron
vperron approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@vperron vperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas de remarques bloquantes, quelques remarques de curiosité.

pipeline/dbt/models/intermediate/_models.yml Show resolved Hide resolved
pipeline/dbt/models/marts/inclusion/marts_inclusion__services.sql Show resolved Hide resolved
pipeline/dbt/models/marts/inclusion/marts_inclusion__services.sql Show resolved Hide resolved
api/src/alembic/versions/20240813_151329_68fe052dc63c_add_score_qualite.py Show resolved Hide resolved
datawarehouse/processings/tests/integration/test_geocoding.py Show resolved Hide resolved
@vmttn vmttn force-pushed the vmttn/feat/add-quality-scoring-to-api branch from f7227f3 to 2861ece Compare October 24, 2024 08:55
vperron
vperron reviewed Oct 24, 2024
View reviewed changes
api/src/data_inclusion/api/inclusion_data/schemas.py
"""),
),
]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du coup on le met directement dans la sortie, mais pas dans le schéma, top.
Je suis d'accord que pas la peine de s'ennuyer avec un feature flag.
Est-ce que on ne veut pas faire un piti test E2E ?
Intéressant que tests existants sur la route de search ne constatent pas de changement, non ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

les tests ont bien été impactés et mis à jour

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

la doc openapi et les format de réponse (liste & recherche) sont bien testés

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'aurais cru que d'autres tests qu'uniquement la doc openapi soit impacté, mais oui en effet j'avais vu ça.

@vperron
Copy link
Contributor

vperron commented Oct 24, 2024

C'est bon pour moi, j'ai hâte de test et de voir les premiers résultats en staging :)

@vmttn vmttn force-pushed the vmttn/feat/add-quality-scoring-to-api branch from 2861ece to a44a2d9 Compare October 24, 2024 12:47
@vmttn vmttn added the deploy-to-staging Permet d'activer le déploiement de la PR en staging. label Oct 24, 2024
@vmttn vmttn merged commit 00f2c11 into main Oct 24, 2024
11 checks passed
@vmttn vmttn deleted the vmttn/feat/add-quality-scoring-to-api branch October 24, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vperron vperron vperron approved these changes

@hlecuyer hlecuyer Awaiting requested review from hlecuyer

Assignees
No one assigned
Labels
deploy-to-staging Permet d'activer le déploiement de la PR en staging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmttn @vperron