Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More support for netcoreapp3.0 #378

Merged
merged 4 commits into from
Sep 30, 2019
Merged

More support for netcoreapp3.0 #378

merged 4 commits into from
Sep 30, 2019

Conversation

slang25
Copy link
Member

@slang25 slang25 commented Sep 30, 2019

See #377

@slang25 slang25 mentioned this pull request Sep 30, 2019
Closed
@slang25 slang25 changed the title Upgrade to netcoreapp3.0 More support for netcoreapp3.0 Sep 30, 2019
slang25
slang25 commented Sep 30, 2019
View reviewed changes
src/Giraffe/Giraffe.fsproj Outdated
<PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="2.2.*" />
<PackageReference Include="Microsoft.AspNetCore.Diagnostics" Version="2.2.*" />
<PackageReference Include="Microsoft.AspNetCore.Authentication" Version="2.2.*" />
<PackageReference Include="Microsoft.AspNetCore.Authorization" Version="3.0.0" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be version 2.2.*, as I assume 3.0.0 was to fix compatibility with netcoreapp3.0 which would now be covered by the framework reference.

@slang25 slang25 marked this pull request as ready for review September 30, 2019 11:04
@slang25
Copy link
Member Author

slang25 commented Sep 30, 2019

This is straddling major aspnetcore versions, that's my only real concern here. MVC just went to netcoreapp3.0 only.

Another thing to note, here I've lowered the major version of Microsoft.AspNetCore.Authorization compared to the Giraffe 4.0 release.

@NinoFloris
Copy link
Member

I recommend looking at
https://twitter.com/khellang/status/1178403463778258944?s=19
To work well with package references (2.x) and framework references (3+) until 2.x goes out of support.

@slang25
Copy link
Member Author

slang25 commented Sep 30, 2019

Thanks @NinoFloris, this PR looks consistent with that approach and is ready for review.

dustinmoris
dustinmoris reviewed Sep 30, 2019
View reviewed changes
tests/Giraffe.Tests/Giraffe.Tests.fsproj Outdated
@@ -45,11 +54,11 @@
<ItemGroup Condition="'$(TargetFramework)' != 'netcoreapp3.0'">
<PackageReference Include="Microsoft.AspNetCore.TestHost" Version="2.2.0" />
</ItemGroup>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these ItemGroups are repleated here.

dustinmoris
dustinmoris reviewed Sep 30, 2019
View reviewed changes
Copy link
Member

@dustinmoris dustinmoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one comment where we included the TestHost reference multiple times.

dustinmoris
dustinmoris approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@dustinmoris dustinmoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustinmoris dustinmoris merged commit eea5a86 into giraffe-fsharp:develop Sep 30, 2019
@slang25 slang25 deleted the remove-explicit-packages branch September 30, 2019 18:16
@NinoFloris
Copy link
Member

Thanks @slang25!

@NinoFloris NinoFloris mentioned this pull request Oct 17, 2019
Closed
@slang25 slang25 mentioned this pull request Nov 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustinmoris dustinmoris dustinmoris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slang25 @NinoFloris @dustinmoris