-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexbox: justify-content: "space-evenly"
#117
Comments
Probably just hasn't been added yet. Feel free to submit a PR. https://github.com/SentiaAnalytics/bs-css/blob/master/src/Css.re#L976 are in the neighborhood of where you would need to put it. |
@lucasweng I just forked and started to add this to find that you just put a PR in 26 minutes ago (#120 ). Thanks! |
@wegry I forgot to add the value `spaceEvenly' to the interface 😅 , so it's not working really. I'll submit another PR to fix it and add a test for it https://github.com/SentiaAnalytics/bs-css/blob/master/src/Css.re#L582 |
My bad too for not catching that. A couple test would be great too.
…On Mon, Feb 25, 2019 at 2:27 AM lucasweng ***@***.***> wrote:
@wegry <https://github.com/wegry> I forgot to add the value `spaceEvenly'
to the interface 😅 , so it's not working really. I'll submit another PR
to fix it and add a test for it
https://github.com/SentiaAnalytics/bs-css/blob/master/src/Css.re#L582
https://github.com/SentiaAnalytics/bs-css/blob/master/src/Css.rei#L354
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE6wCf3R8yl3p5zFrJISl17428HNbkmMks5vQzvngaJpZM4bI2qI>
.
|
fixed in 8.0.2 |
Is there a reason why "justifyContent(`spaceEvenly)" is missing from the Flexbox implementation? Is it hard to add?
The text was updated successfully, but these errors were encountered: