Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexbox: justify-content: "space-evenly" #117

Closed
rjhilgefort opened this issue Feb 22, 2019 · 5 comments
Closed

Flexbox: justify-content: "space-evenly" #117

rjhilgefort opened this issue Feb 22, 2019 · 5 comments

Comments

@rjhilgefort
Copy link

rjhilgefort commented Feb 22, 2019

Is there a reason why "justifyContent(`spaceEvenly)" is missing from the Flexbox implementation? Is it hard to add?

@wegry
Copy link
Contributor

wegry commented Feb 22, 2019

Probably just hasn't been added yet. Feel free to submit a PR.

https://github.com/SentiaAnalytics/bs-css/blob/master/src/Css.re#L976
https://github.com/SentiaAnalytics/bs-css/blob/master/src/Css.rei#L585

are in the neighborhood of where you would need to put it.

@rjhilgefort
Copy link
Author

@lucasweng I just forked and started to add this to find that you just put a PR in 26 minutes ago (#120 ). Thanks!

@lucasweng
Copy link
Collaborator

@wegry I forgot to add the value `spaceEvenly' to the interface 😅 , so it's not working really. I'll submit another PR to fix it and add a test for it

https://github.com/SentiaAnalytics/bs-css/blob/master/src/Css.re#L582
https://github.com/SentiaAnalytics/bs-css/blob/master/src/Css.rei#L354

@wegry
Copy link
Contributor

wegry commented Feb 25, 2019 via email

@giraud
Copy link
Owner

giraud commented Feb 25, 2019

fixed in 8.0.2

@giraud giraud closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants