Fix frame selection bugs #1256
Merged
Fix frame selection bugs #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't want to commit the package-lock.json file because of the way girder builds things. |
manthey
reviewed
Aug 9, 2023
| import { nextTick } from 'vue'; | ||
| import { makeDraggableSVG } from '../utils/drag'; | ||
| import {restRequest} from '@girder/core/rest'; | ||
| import {nextTick} from 'vue'; // eslint-disable-line |
There was a problem hiding this comment.
We could also do import Vue from 'vue'; and then use Vue.nextTick instead of nextTick, if you think that is better than the eslint disable.
There was a problem hiding this comment.
Ok, I like that better, thanks! Changed in 1617726
manthey
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several bugs within the frame selection widget; each bug is described in the commit message that provides the respective fix.