Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes on send and reception FACe #15

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Changes on send and reception FACe #15

merged 6 commits into from
Jul 16, 2024

Conversation

nvillarroya
Copy link
Contributor

@nvillarroya nvillarroya commented May 28, 2024

Breaks Compatibilities:

send method changes.

  • Previous behavior has respected in a new function send_by_filename who has the same parameters.
  • New behavior
    • invoice_filename: Filename of the invoice
    • invoice_content: b64encoded content of the file who want to send
    • attachments: Same as previous behavior

Return values

  • By Default return values are directly from response and not return specific objects.
  • Compatibility with previous behavior is so easy. Only need to pass a new parameter on init on kwargs parameters with result_obj=True
     ...
    face = FACe(
           environment=self.environment,
           certificate=self.certificate,
           email=self.email, 
           result_obj=True
       )
    

@nvillarroya nvillarroya self-assigned this May 28, 2024
@nvillarroya nvillarroya requested a deployment to avellana-comer-erp June 11, 2024 13:12 Pending
@nvillarroya nvillarroya temporarily deployed to avellana-comer-erp June 11, 2024 13:13 Inactive
@nvillarroya nvillarroya deployed to avellana-comer-erp June 11, 2024 14:21 Active
@nvillarroya nvillarroya added this to the v0.2.0 milestone Jun 17, 2024
@nvillarroya nvillarroya marked this pull request as ready for review June 17, 2024 13:06
@guilleJB guilleJB changed the title canvis enviament i recepcio face Changes on send and reception FACe Jul 16, 2024
@guilleJB guilleJB added the major label Jul 16, 2024
@polsala polsala merged commit 4ab1fc0 into master Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants