Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imp protocol behaviour with handshake retries #10

Merged
merged 2 commits into from
Feb 10, 2019
Merged

Imp protocol behaviour with handshake retries #10

merged 2 commits into from
Feb 10, 2019

Conversation

MiquelIR
Copy link
Contributor

@MiquelIR MiquelIR commented Feb 7, 2019

No description provided.

@MiquelIR MiquelIR added the enhancement New feature or request label Feb 7, 2019
@MiquelIR MiquelIR self-assigned this Feb 7, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 39

  • 10 of 18 (55.56%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 75.361%
Changes Missing Coverage Covered Lines Changed/Added Lines %
iec870ree/protocol.py 10 18 55.56%
Totals Coverage Status
Change from base Build 37: -0.5%
Covered Lines: 679
Relevant Lines: 901
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 39

  • 10 of 18 (55.56%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 75.361%
Changes Missing Coverage Covered Lines Changed/Added Lines %
iec870ree/protocol.py 10 18 55.56%
Totals Coverage Status
Change from base Build 37: -0.5%
Covered Lines: 679
Relevant Lines: 901
💛 - Coveralls

@MiquelIR MiquelIR mentioned this pull request Feb 8, 2019
Closed
@ecarreras ecarreras merged commit 4431a8e into master Feb 10, 2019
@ecarreras ecarreras deleted the imp_protocol_behaviour_with_retries branch February 10, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecarreras ecarreras Awaiting requested review from ecarreras

Assignees

@MiquelIR MiquelIR

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiquelIR @coveralls @ecarreras