Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attachment header getting #29

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Fix attachment header getting #29

merged 1 commit into from
Sep 10, 2018

Conversation

jaumef
Copy link
Contributor

@jaumef jaumef commented Sep 10, 2018

Solves a bug when parsing the email for attachments.

If the part was not multipart or text but it wasn't an attachment, or a correctly headed one, an exception was being thrown (ValueError: Bool is not iterable)

If the part does not have the "Content-Disposition" header, we'll ignore it.

Todo

  • Fix bug
  • Improve the tests to catch the bug

@jaumef jaumef self-assigned this Sep 10, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.127% when pulling 5cba935 on fix_attachment_getter into a5a9596 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants