-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Serbo-Croatian localization #1365
Conversation
@matijakljajic is attempting to deploy a commit to the giscus Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hvala!
I'll merge this now, but do you think it's sensible to use the hr
language code instead, and have the hbs
code as an alias/fall back to the hr
translation files? I'm not sure about the political implications, but it seems to be more common to use the name "Croatian" if it exclusively uses the Latin alphabet, and "Serbian" if it uses the Cyrillic alphabet. At least, that's how Google Translate does it.
Google Translate may work like that but Serbian has two official scripts, Cyrillic and Latin. (btw Google Translate is not reliable at all for languages not supported by DeepL AFAIK, best to use that for translations) I've purposely written the localization in a way where it tries to stay neutral regarding the dialect and be inclusive to all variants, at least as much as I could, it's open to updates if not adequate. (every variant uses Latin as an official script) Croatian and Serbian officially have words which do not appear in both dictionaries even if mutually intelligible, thus it's best to leave the Consequently, if someone wants to add Serbian Cyrillic or Croatian with the use of more localized words they're free to do so with I feel like it's best not to complicate things with |
@matijakljajic That's very helpful, thanks! I'll leave this as-is, then. |
Also I may have accidentally left out this, thus it's failing the build process. Sorry, but please amend or apply a quick-fix. |
Oops, thanks, fixed in #1367. |
No description provided.