Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security headers #147

Merged
merged 7 commits into from
Jul 25, 2021
Merged

Add security headers #147

merged 7 commits into from
Jul 25, 2021

Conversation

laymonage
Copy link
Member

@laymonage laymonage commented Jul 25, 2021 •
edited
Loading

Part of #40.

Slightly related to utterance/utterances#527, we set Content-Security-Policy with frame-ancestors that's set to the current origin if it's allowed according to giscus.json settings. As a result, we no longer show the message implemented in #125 (the browser will now simply refuse to load the iframe).

@vercel
Copy link

vercel bot commented Jul 25, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/laymonage/giscus/71KCJx164MUfi4HR2qrwwiyyzu5M
✅ Preview: https://giscus-git-security-headers-laymonage.vercel.app

@laymonage laymonage merged commit c96014b into main Jul 25, 2021
@laymonage laymonage deleted the security-headers branch July 25, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@laymonage