Resumable uploads via tusd #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to opt-in to using
tusdto enable resumable uploads.tusdis the reference implementation of the tus.io resumable upload protocol and is supported by this git-lfs PR which should hopefully be in git-lfs v1.3.I couldn't create meaningful tests for this without making the project dependent on the tus codebase, which is quite large (recursive dependencies). This is also the reason I chose to implement it by calling the
tusdbinary (which the user must have installed when opting in), rather than directly referencing the tus code - that would have been more elegant and wouldn't have had to assume knowledge of the tusd storage model, but it would have bloated the vendor directory horribly so I consider this the lesser of the two evils. Hope you agree 😄I just run it through its paces manually with a test repo instead.