Fix crash with checkin policies enabled #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to make them easier to identify. While at it, remove one unneeded trace.
If checkin policies are enabled via enable_checkin_policies_support.bat the git-tfs binary is modified via CorFlags to run as a 32bit process, as the checkin policies are only available in 32bit (not sure if this is still the case for VS2022, but at least for VS2019 and VS2017 this is the case). The code uses internally a different code path if it runs as 32bit process, as the corresponding libraries to enable loading the private registry only works in 32bit. Commit a515071 ("Add support for checkin policies for VS2017 and VS2019", 2020-11-02) introduced the support for loading the private registry where e.g. installed extensions and/or code review policies are stored, but it accidentally had some debugging leftovers trying to access a specific registry key. This key does not exist if no VS extensions and/or checkin policies are installed and therefore made the git-tfs application terminate with an exception. Remove this dead code and fix this error, which was noticed when testing the VS2022 support whitout any extensions installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.