Browse files

string_list_add_refs_by_glob(): add a comment about memory management

Since string_list_add_one_ref() adds refname to the string list, but
the lifetime of refname is limited, it is important that the
string_list passed to string_list_add_one_ref() has strdup_strings
set.  Document this fact.

All current callers do the right thing.

Signed-off-by: Michael Haggerty <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
1 parent d235e99 commit 8c46bf904fe95105faaa1823332c91d2802182c2 @mhagger mhagger committed with gitster May 25, 2013
Showing with 4 additions and 0 deletions.
  1. +4 −0 notes.c
4 notes.c
@@ -927,8 +927,12 @@ static int string_list_add_one_ref(const char *refname, const unsigned char *sha
return 0;
+ * The list argument must have strdup_strings set on it.
+ */
void string_list_add_refs_by_glob(struct string_list *list, const char *glob)
+ assert(list->strdup_strings);
if (has_glob_specials(glob)) {
for_each_glob_ref(string_list_add_one_ref, glob, list);
} else {

0 comments on commit 8c46bf9

Please sign in to comment.