-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ticket-537) user bindUser for group detection #247
Conversation
At a quick glance you are changing the existing behavior to solve your issue, but you may be breaking other installs. This needs some discussion on the mailing list. Clearly with LDAP what works for some may not work for all - hence the reason for your PR. |
new config key : "realm.ldap.groupQueryWithUser"
created new branch and extracted new behaviour into it with a config key ( commit f04f891) |
…ebase to develop
…ebase to develop
rebased to develop, not sure about the "since 1.7.0" Information in defaults.properties |
Hi @RainerW. Github doesn't allow you to merge a PR to another branch AFAIK i.e. if I merge now, your change will merge to Having said that, while your change solves your problem and may solve #920, I don't like this solution - changing the behavior of |
This should is a fix for *( https://code.google.com/p/gitblit/issues/detail?id=537) *
-> For security reason a normal user cannot read groups from our LDAP, so in this case the search user has to be used for group/team detection.
would appreciate some feedback :
1: Based on the comment "// Binding will stop any LDAP-Injection Attacks ...." should there be a separate setting for enabling this 'feature', or what actually is a LDAP-Injection Attack?
2: getLdapConnection() should now be called createLdapConnection() ?
Edit:
Original google code ticket is not available anymore?
Problem was: