-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize components by feature #4138
Conversation
9f1d0dc
to
22789f8
Compare
Looks great! |
Cool cool, perhaps we can land as a partial step if it's going in the right direction? *edit: alternatively, feel free to add more work first, I'll let you guys decide when to merge. I will be offline today and likely all weekend. |
@mtsgrd I've got a PR that I'd like to merge first but after that, I'm happy to merge as a first step |
Yup, no other comments or hold-ups from me. Feel free to merge as first step whenever yuo're ready @Caleb-T-Owens. Just noticed theres a bunch of merge conflicts now. Are you still waiting to merge your PR Caleb or has it already been merged? If its already been merged, then I can take a look at cleaning up these conflicts and getting this merged |
@ndom91 Yes, I've merged my thing. They are my conflicts so I'm happy to also resolve them if you want |
@Caleb-T-Owens okay I guess we're not in a hurry to merge this, right. I'll leave it for you for next week then 😊 |
22789f8
to
8beeb37
Compare
I'm the one who dropped this 140+ file change unannounced, so I just went ahead and rebased it. 😏 |
21365f3
to
95eed4d
Compare
95eed4d
to
2b2d22c
Compare
I've been on a train for the last 3h, thought I could take a stab at moving some files around. Let me know what you guys think? *edit: had to stop halfway through, approaching my end station.