Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize components by feature #4138

Merged
merged 12 commits into from
Jun 24, 2024
Merged

Organize components by feature #4138

merged 12 commits into from
Jun 24, 2024

Conversation

mtsgrd
Copy link
Contributor

@mtsgrd mtsgrd commented Jun 20, 2024

I've been on a train for the last 3h, thought I could take a stab at moving some files around. Let me know what you guys think? *edit: had to stop halfway through, approaching my end station.

@mtsgrd mtsgrd marked this pull request as draft June 20, 2024 20:34
@mtsgrd mtsgrd changed the title Organise components by feature Organize components by feature Jun 20, 2024
@mtsgrd mtsgrd force-pushed the Organise-components-by-feature branch from 9f1d0dc to 22789f8 Compare June 20, 2024 21:04
@Caleb-T-Owens
Copy link
Contributor

Looks great!

@mtsgrd
Copy link
Contributor Author

mtsgrd commented Jun 21, 2024

Cool cool, perhaps we can land as a partial step if it's going in the right direction? *edit: alternatively, feel free to add more work first, I'll let you guys decide when to merge. I will be offline today and likely all weekend.

@Caleb-T-Owens
Copy link
Contributor

@mtsgrd I've got a PR that I'd like to merge first but after that, I'm happy to merge as a first step

@ndom91
Copy link
Contributor

ndom91 commented Jun 21, 2024

Yup, no other comments or hold-ups from me. Feel free to merge as first step whenever yuo're ready @Caleb-T-Owens.

Just noticed theres a bunch of merge conflicts now. Are you still waiting to merge your PR Caleb or has it already been merged? If its already been merged, then I can take a look at cleaning up these conflicts and getting this merged

@Caleb-T-Owens
Copy link
Contributor

@ndom91 Yes, I've merged my thing. They are my conflicts so I'm happy to also resolve them if you want

@ndom91
Copy link
Contributor

ndom91 commented Jun 21, 2024

@Caleb-T-Owens okay I guess we're not in a hurry to merge this, right. I'll leave it for you for next week then 😊

@mtsgrd mtsgrd force-pushed the Organise-components-by-feature branch from 22789f8 to 8beeb37 Compare June 21, 2024 18:11
@mtsgrd
Copy link
Contributor Author

mtsgrd commented Jun 21, 2024

I'm the one who dropped this 140+ file change unannounced, so I just went ahead and rebased it. 😏

@mtsgrd mtsgrd marked this pull request as ready for review June 21, 2024 19:01
@mtsgrd mtsgrd force-pushed the Organise-components-by-feature branch from 21365f3 to 95eed4d Compare June 24, 2024 05:05
@mtsgrd mtsgrd force-pushed the Organise-components-by-feature branch from 95eed4d to 2b2d22c Compare June 24, 2024 05:08
@mtsgrd mtsgrd merged commit 92daa19 into master Jun 24, 2024
16 checks passed
@mtsgrd mtsgrd deleted the Organise-components-by-feature branch June 24, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants