Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show notification when subscribing to mailing list #72

Merged
merged 1 commit into from
Apr 12, 2018
Merged

show notification when subscribing to mailing list #72

merged 1 commit into from
Apr 12, 2018

Conversation

bdr99
Copy link
Contributor

@bdr99 bdr99 commented Apr 11, 2018

This is a redo of #59 which was incorrectly rebased.

@bdr99 bdr99 mentioned this pull request Apr 11, 2018
Closed
@eshellman
Copy link
Contributor

I'll merge this to be expeditious, but I have two comments:

  1. is it required, or good practice, to set type="text/javascript" on the <script> element?
  2. is there a reason to use a file extension ".htmldjango" as a file extenson? it's not consistent with other templates in this repo.

@eshellman eshellman merged commit 82e8e46 into master Apr 12, 2018
@eshellman
Copy link
Contributor

deployed to production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdr99 @eshellman