Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OPT_RERERE_AUTOUPDATE's "unspecified" value consistent with other unspecified values #201

Open
dscho opened this issue May 17, 2019 · 3 comments
Open

Make OPT_RERERE_AUTOUPDATE's "unspecified" value consistent with other unspecified values #201

dscho opened this issue May 17, 2019 · 3 comments
Labels
leftoverbits From the Git mailing list: https://lore.kernel.org/git/?q=%23leftoverbits

Comments

@dscho
Copy link
Member

dscho commented May 17, 2019

In Git's source code, the (unwritten) convention is to use -1 for unspecified values of command-line options of config settings.

Currently, the rerere.autoUpdate setting disagrees, and we should rectify this.

See https://public-inbox.org/git/nycvar.QRO.7.76.6.1901181443350.41@tvgsbejvaqbjf.bet/
@dscho dscho added the leftoverbits From the Git mailing list: https://lore.kernel.org/git/?q=%23leftoverbits label May 17, 2019
@weekly-digest weekly-digest bot mentioned this issue May 19, 2019
Closed
@PhilipOakley
Copy link

Also (should be a new issue maybe) actually write somewhere. e.g. the CodingGuidelines "the (-unwritten-) convention is to use -1 for unspecified values of command-line options of config settings"

@dscho
Copy link
Member Author

dscho commented May 29, 2019 •
edited

Also (should be a new issue maybe) actually write somewhere. e.g. the CodingGuidelines "the (-unwritten-) convention is to use -1 for unspecified values of command-line options of config settings"

Definitely worth a new ticket. How about it, @PhilipOakley?

@PhilipOakley
Copy link

Definitely worth a new ticket. How about it, @PhilipOakley?

It's in/on my pile of todo lists 😉 ... (actually that's two actions: a) create issue, b) write three line doc update with 25 line commit message over 4 versions;-)

This was referenced May 29, 2019
Open
Open
PhilipOakley pushed a commit to PhilipOakley/git that referenced this issue May 30, 2019
doc: CodingGuidelines: use -1 for unspecified cli options
a360e02 
This documents previous folk wisdom as discussed in
https://public-inbox.org/git/xmqq7ecw7vbb.fsf@gitster-ct.c.googlers.com/.

Raised recently in gitgitgadget#201
and git-for-windows#237.

Signed-off-by: Philip Oakley <philipoakley@iee.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
leftoverbits From the Git mailing list: https://lore.kernel.org/git/?q=%23leftoverbits
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dscho @PhilipOakley