Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc placeholders #1626

Closed
wants to merge 2 commits into from
Closed

Conversation

jnavila
Copy link

@jnavila jnavila commented Dec 23, 2023

While setting up a check of (the absence of) translations of commands, options and environment variable in the manpages in the manpage translation project, some false positives appeared.

Here is a series that enforces the formatting rules for placeholders in documentation and help.

The CodingGuidelines documents stipulates that multi-word placeholders
are to be separated by dashes, not underscores nor spaces.

Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
Any string that is not meant to be used verbatim in the documentation
should be marked as a placeholder.

Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
@jnavila
Copy link
Author

jnavila commented Dec 24, 2023

/preview

Copy link

gitgitgadget bot commented Dec 24, 2023

Preview email sent as pull.1626.git.1703412798.gitgitgadget@gmail.com

@jnavila
Copy link
Author

jnavila commented Dec 25, 2023

/submit

Copy link

gitgitgadget bot commented Dec 25, 2023

Submitted as pull.1626.git.1703539287.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-1626/jnavila/fix_doc_placeholders-v1

To fetch this version to local tag pr-1626/jnavila/fix_doc_placeholders-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-1626/jnavila/fix_doc_placeholders-v1

Copy link

gitgitgadget bot commented Dec 26, 2023

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Jean-Noël Avila via GitGitGadget" <gitgitgadget@gmail.com> writes:

> While setting up a check of (the absence of) translations of commands,
> options and environment variable in the manpages in the manpage translation
> project, some false positives appeared.
>
> Here is a series that enforces the formatting rules for placeholders in
> documentation and help.

Nice.  Will take a look and then queue.  Thanks.

>
> Jean-Noël Avila (2):
>   doc: enforce dashes in placeholders
>   doc: enforce placeholders in documentation
>
>  Documentation/diff-options.txt             |  2 +-
>  Documentation/git-blame.txt                |  2 +-
>  Documentation/git-bugreport.txt            |  4 ++--
>  Documentation/git-commit-graph.txt         |  2 +-
>  Documentation/git-config.txt               |  8 ++++----
>  Documentation/git-cvsserver.txt            |  4 ++--
>  Documentation/git-daemon.txt               | 10 +++++-----
>  Documentation/git-diagnose.txt             |  2 +-
>  Documentation/git-difftool.txt             |  2 +-
>  Documentation/git-fast-import.txt          |  4 ++--
>  Documentation/git-fetch.txt                |  4 ++--
>  Documentation/git-filter-branch.txt        |  6 +++---
>  Documentation/git-format-patch.txt         | 20 ++++++++++----------
>  Documentation/git-mv.txt                   |  2 +-
>  Documentation/git-notes.txt                |  2 +-
>  Documentation/git-replace.txt              |  6 +++---
>  Documentation/git-revert.txt               |  4 ++--
>  Documentation/git-send-email.txt           |  2 +-
>  Documentation/git-status.txt               |  4 ++--
>  Documentation/git-submodule.txt            |  4 ++--
>  Documentation/git-svn.txt                  | 18 +++++++++---------
>  Documentation/git-tag.txt                  |  2 +-
>  Documentation/git.txt                      |  4 ++--
>  Documentation/gitdiffcore.txt              |  8 ++++----
>  Documentation/gitformat-index.txt          |  4 ++--
>  Documentation/githooks.txt                 |  8 ++++----
>  Documentation/gitk.txt                     |  4 ++--
>  Documentation/gitprotocol-capabilities.txt |  2 +-
>  Documentation/gitprotocol-http.txt         | 14 +++++++-------
>  Documentation/gitprotocol-v2.txt           |  8 ++++----
>  Documentation/gitsubmodules.txt            |  4 ++--
>  Documentation/gitweb.conf.txt              | 10 +++++-----
>  Documentation/gitweb.txt                   |  2 +-
>  Documentation/trace2-target-values.txt     |  2 +-
>  Documentation/urls.txt                     |  8 ++++----
>  Documentation/user-manual.txt              |  4 ++--
>  builtin/commit-graph.c                     |  2 +-
>  37 files changed, 99 insertions(+), 99 deletions(-)
>
>
> base-commit: 564d0252ca632e0264ed670534a51d18a689ef5d
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1626%2Fjnavila%2Ffix_doc_placeholders-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1626/jnavila/fix_doc_placeholders-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1626

Copy link

gitgitgadget bot commented Dec 26, 2023

This branch is now known as ja/doc-placeholders-fix.

Copy link

gitgitgadget bot commented Dec 26, 2023

This patch series was integrated into seen via git@b068324.

@gitgitgadget gitgitgadget bot added the seen label Dec 26, 2023
Copy link

gitgitgadget bot commented Dec 28, 2023

This patch series was integrated into seen via git@ba1797b.

Copy link

gitgitgadget bot commented Dec 28, 2023

There was a status update in the "New Topics" section about the branch ja/doc-placeholders-fix on the Git mailing list:

Docfix.

Needs review.
source: <pull.1626.git.1703539287.gitgitgadget@gmail.com>

Copy link

gitgitgadget bot commented Dec 28, 2023

This patch series was integrated into seen via git@9841bb8.

Copy link

gitgitgadget bot commented Jan 2, 2024

This patch series was integrated into seen via git@1a08b10.

Copy link

gitgitgadget bot commented Jan 3, 2024

This patch series was integrated into seen via git@f1821d6.

Copy link

gitgitgadget bot commented Jan 3, 2024

There was a status update in the "Cooking" section about the branch ja/doc-placeholders-fix on the Git mailing list:

Docfix.

Needs review.
source: <pull.1626.git.1703539287.gitgitgadget@gmail.com>

Copy link

gitgitgadget bot commented Jan 3, 2024

This patch series was integrated into seen via git@1d41de1.

Copy link

gitgitgadget bot commented Jan 4, 2024

This patch series was integrated into seen via git@7c02866.

Copy link

gitgitgadget bot commented Jan 5, 2024

This patch series was integrated into seen via git@5a9f78a.

Copy link

gitgitgadget bot commented Jan 6, 2024

There was a status update in the "Cooking" section about the branch ja/doc-placeholders-fix on the Git mailing list:

Docfix.

Needs review.
source: <pull.1626.git.1703539287.gitgitgadget@gmail.com>

Copy link

gitgitgadget bot commented Jan 9, 2024

This patch series was integrated into seen via git@63be843.

Copy link

gitgitgadget bot commented Jan 10, 2024

There was a status update in the "Cooking" section about the branch ja/doc-placeholders-fix on the Git mailing list:

Docfix.

Needs review.
source: <pull.1626.git.1703539287.gitgitgadget@gmail.com>

Copy link

gitgitgadget bot commented Jan 10, 2024

This patch series was integrated into seen via git@4408167.

Copy link

gitgitgadget bot commented Jan 12, 2024

There was a status update in the "Cooking" section about the branch ja/doc-placeholders-fix on the Git mailing list:

Docfix.

Needs review.
source: <pull.1626.git.1703539287.gitgitgadget@gmail.com>

Copy link

gitgitgadget bot commented Jan 13, 2024

This patch series was integrated into seen via git@17a4e8a.

Copy link

gitgitgadget bot commented Jan 16, 2024

This patch series was integrated into seen via git@3b1934e.

Copy link

gitgitgadget bot commented Jan 16, 2024

There was a status update in the "Cooking" section about the branch ja/doc-placeholders-fix on the Git mailing list:

Docfix.

Needs review.
source: <pull.1626.git.1703539287.gitgitgadget@gmail.com>

Copy link

gitgitgadget bot commented Jan 17, 2024

This patch series was integrated into seen via git@54ffad0.

Copy link

gitgitgadget bot commented Jan 18, 2024

This patch series was integrated into seen via git@9108b67.

Copy link

gitgitgadget bot commented Jan 26, 2024

This patch series was integrated into seen via git@fc7af06.

Copy link

gitgitgadget bot commented Jan 27, 2024

There was a status update in the "Cooking" section about the branch ja/doc-placeholders-fix on the Git mailing list:

Docfix.

Needs review.
source: <pull.1626.git.1703539287.gitgitgadget@gmail.com>

Copy link

gitgitgadget bot commented Jan 29, 2024

This patch series was integrated into seen via git@4dfd20a.

Copy link

gitgitgadget bot commented Jan 30, 2024

This patch series was integrated into seen via git@1204224.

Copy link

gitgitgadget bot commented Jan 30, 2024

There was a status update in the "Cooking" section about the branch ja/doc-placeholders-fix on the Git mailing list:

Docfix.

Needs review.
source: <pull.1626.git.1703539287.gitgitgadget@gmail.com>

Copy link

gitgitgadget bot commented Jan 30, 2024

This patch series was integrated into seen via git@3dcd43f.

Copy link

gitgitgadget bot commented Jan 31, 2024

This patch series was integrated into seen via git@94d74e5.

Copy link

gitgitgadget bot commented Jan 31, 2024

This patch series was integrated into seen via git@9a093bb.

Copy link

gitgitgadget bot commented Feb 1, 2024

This patch series was integrated into seen via git@36a3bfc.

Copy link

gitgitgadget bot commented Feb 1, 2024

This patch series was integrated into seen via git@72f72ee.

Copy link

gitgitgadget bot commented Feb 2, 2024

This patch series was integrated into seen via git@4c3c855.

Copy link

gitgitgadget bot commented Feb 3, 2024

There was a status update in the "Cooking" section about the branch ja/doc-placeholders-fix on the Git mailing list:

Docfix.

Will merge to 'next'.
source: <pull.1626.git.1703539287.gitgitgadget@gmail.com>

Copy link

gitgitgadget bot commented Feb 3, 2024

This patch series was integrated into seen via git@c0f66a1.

Copy link

gitgitgadget bot commented Feb 3, 2024

There was a status update in the "Cooking" section about the branch ja/doc-placeholders-fix on the Git mailing list:

Docfix.

Will merge to 'next'.
source: <pull.1626.git.1703539287.gitgitgadget@gmail.com>

Copy link

gitgitgadget bot commented Feb 6, 2024

This patch series was integrated into seen via git@798074c.

Copy link

gitgitgadget bot commented Feb 6, 2024

This patch series was integrated into next via git@047da8c.

@gitgitgadget gitgitgadget bot added the next label Feb 6, 2024
Copy link

gitgitgadget bot commented Feb 7, 2024

This patch series was integrated into seen via git@47b5cf6.

Copy link

gitgitgadget bot commented Feb 7, 2024

There was a status update in the "Cooking" section about the branch ja/doc-placeholders-fix on the Git mailing list:

Docfix.

Will merge to 'master'.
source: <pull.1626.git.1703539287.gitgitgadget@gmail.com>

Copy link

gitgitgadget bot commented Feb 7, 2024

This patch series was integrated into seen via git@ab61a68.

Copy link

gitgitgadget bot commented Feb 7, 2024

This patch series was integrated into seen via git@ae1588d.

Copy link

gitgitgadget bot commented Feb 8, 2024

This patch series was integrated into seen via git@b0425ab.

Copy link

gitgitgadget bot commented Feb 8, 2024

This patch series was integrated into seen via git@d4b6719.

Copy link

gitgitgadget bot commented Feb 8, 2024

This patch series was integrated into seen via git@2a10505.

Copy link

gitgitgadget bot commented Feb 8, 2024

This patch series was integrated into master via git@2a10505.

Copy link

gitgitgadget bot commented Feb 8, 2024

This patch series was integrated into next via git@2a10505.

@gitgitgadget gitgitgadget bot added the master label Feb 8, 2024
@gitgitgadget gitgitgadget bot closed this Feb 8, 2024
Copy link

gitgitgadget bot commented Feb 8, 2024

Closed via 2a10505.

@jnavila jnavila deleted the fix_doc_placeholders branch February 24, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant