feat(view): drawSubGraph function without any relationship between commits & e2e test to click on cluster #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 23, 2023 02:37
ytaek
approved these changes
Sep 25, 2023
| @@ -11,11 +11,20 @@ export function getGraphHeight(clusterSizes: number[]) { | |||
| return clusterSizes.length * CLUSTER_HEIGHT + clusterSizes.length * NODE_GAP + NODE_GAP; | |||
| } | |||
|
|
|||
| export function getStartYEndY(d: ClusterGraphElement, a: number, detailElementHeight: number) { | |||
| export function getTranslateAfterSelect( | ||
| d: ClusterGraphElement, | ||
| i: number, | ||
| detailElementHeight: number, | ||
| isPrev = false | ||
| isPrev = false // TODO - 해당 인자를 개선해야할듯 |
There was a problem hiding this comment.
// TODO 는 좋은데, 한글 comment는 지양하면 좋겠습니다~.
There was a problem hiding this comment.
네 알겠습니다!
개발 중에 작성한 부분인데 실수로 commit에 들어갔네요 ㅠ
KyuTae98
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
subGraph
Result
subGraph 화면
e2e test report(transform test, subGraph(x))
Work list
Discussion