Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): Prevent multiple webview panel instances #495

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

Jinho1011
Copy link
Member

Related issue

fixes #315

Result

webview panel 이 계속 생성되는 문제를 해결했습니다.
Sep-27-2023 15-59-29

Discussion

@2taesung
Copy link
Contributor

2taesung commented Oct 1, 2023

이슈랑에도 언급된 webview panel 이 정확히 어떤건가요 ... ?!

@Jinho1011
Copy link
Member Author

이슈랑에도 언급된 webview panel 이 정확히 어떤건가요 ... ?!

githru 화면(또는 창)이라고 생각해주시면 됩니다!

@Jinho1011
Copy link
Member Author

빌드 오류 고쳤습니다!

Copy link
Contributor

@ytaek ytaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ytaek
Copy link
Contributor

ytaek commented Oct 5, 2023

release 발행을 위해 제가 머지할께요!

@ytaek ytaek merged commit 0a6c5b7 into githru:main Oct 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] webview panel globally 하나만 띄우기
3 participants