Add rake task to check grammars #4451
Conversation
| For example, on macOS with [Homebrew](http://brew.sh/): `brew install cmake pkg-config icu4c && brew cask install docker` and on Ubuntu: `apt-get install cmake pkg-config libicu-dev docker-ce`. | ||
|
|
||
| The latest version of Bundler v1 can be installed with `gem install bundler -v "~>1.10"`. | ||
|
|
There was a problem hiding this comment.
I've moved the dependencies above "Getting started" as it's a lot easier to get started once you've met all the dependencies 😁
|
Perfect :) Since then I sent you a pull request for a preliminary version of Syntax Highlighter for Vyper (second Ethereum smart contract language), used for example in these contracts: https://github.com/Uniswap/contracts-vyper/blob/master/contracts/uniswap_exchange.vy I think it's a low risk to include this in current release, so if you manage... if not, would be great if next time. Highlighter follows the same agreement as the one for Solidity (.sublime-syntax on master and tmLanguage on |
There was a problem hiding this comment.
Nothing glaring that jumps out at me, but don't forget I have a very bastardised knowledge of Ruby which is ultimately product of Perl and CoffeeScript knowledge. 😉 (Both languages are similar enough to Ruby that every assumption I've ever made about the language has so far been correct)/.
|
Eh... that review was supposed to have been a comment, not a change request. Bit gauche of me, sorry. 😞 |
NP. All the same to me 😄 |
Description
In my ongoing quest to prevent losing a grammar again without noticing, this PR adds a new rake task that is run whenever the grammars are updated. It should confirm that no grammars have suddenly gone missing and also flag if there are any new errors.
Sadly, we have to rely on a hardcoded known error account until such time as we've got 100% error free grammars, which isn't likely to happen any time soon. This is however sufficient enough to prompt anyone making a new release to check the output before actually releasing.
While I was updating the release section on the CONTRIBUTING.md, I also tweaked the dependencies and getting started sections following the feedback in #4449
Checklist: