Better handle shebangs with = after the interpreter #4485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As pointed out in #4447, the shebang strategy is a little over enthusiastic when it comes to parsing the shebang in a file if that shebang contains
=
after the interpreter resulting in the interpreter being completely missed and the file marked as plain text:This PR addresses that by making the match for the preceding env vars tighter and then iterating over that match to catch them all, before moving onto the interpreter.
Now the same check gives us the correct interpreter:
... and works if we put env vars before the interpreter too:
Kudos to @pchaigno for the simple solution. 🙇
Checklist:
Fixes #4447