trivial: add .hack extension for Hack language #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukos-git
suggested changes
Jul 24, 2019
| @@ -2003,6 +2003,7 @@ Hack: | |||
| codemirror_mode: php | |||
| codemirror_mime_type: application/x-httpd-php | |||
| extensions: | |||
| - ".hack" | |||
| - ".hh" | |||
| - ".php" | |||
There was a problem hiding this comment.
if php is a deprecated extension and not working anymore anyway with hack, then remove it because we are better of having the extension assigned to plain php.
There was a problem hiding this comment.
It's still very commonly used: https://github.com/search?q=extension%3Aphp+async+await&type=Code
So we should probably not remove it in the near future.
There was a problem hiding this comment.
@jjergus We don't retroactively remove extensions due to declining popularity. If an extension was proven to have enough real-world distribution at the time it was added, that's enough for us.
`.hack` was agreed on as the main extension for Hack files in the future, and is already used by standard Hack libraries (e.g. https://github.com/hhvm/hacktest/tree/master/src) and official documentation (e.g. https://docs.hhvm.com/hack/getting-started/getting-started#your-first-hack-program__3.-write-your-first-hack-program). This should fix syntax highlighting for pull requests such as https://github.com/hhvm/hacktest/pull/84/files For context, `.php` is deprecated for Hack files since the languages are no longer compatible, and `.hh` is discouraged because it can cause confusion with C++ header files.
|
Sample file added. |
Alhadis
approved these changes
Aug 12, 2019
lildude
approved these changes
Aug 12, 2019
|
Thanks for the review and suggestions! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.hackwas agreed on as the main extension for Hack files in the future, and is already used by standard Hack libraries (example) and official documentation (example).This should fix syntax highlighting for pull requests such as https://github.com/hhvm/hacktest/pull/84/files
For context,
.phpis deprecated for Hack files since the languages are no longer compatible, and.hhis discouraged because it can cause confusion with C++ header files.